Skip to content

Commit 02412e8

Browse files
committed
bundle: simplify flatpak with conditional gates
1 parent c24028b commit 02412e8

File tree

17 files changed

+18
-91
lines changed

17 files changed

+18
-91
lines changed

Library/Homebrew/bundle/flatpak_installer.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,7 @@ def self.reset!
99
end
1010

1111
def self.preinstall!(name, verbose: false, remote: "flathub", **_options)
12-
unless Bundle.flatpak_installed?
13-
puts "Installing flatpak. It is not currently installed." if verbose
14-
Bundle.brew("install", "--formula", "flatpak", verbose:)
15-
raise "Unable to install #{name} package. Flatpak installation failed." unless Bundle.flatpak_installed?
16-
end
12+
return false unless Bundle.flatpak_installed?
1713

1814
# Check if package is installed at all (regardless of remote)
1915
if package_installed?(name)
@@ -25,6 +21,7 @@ def self.preinstall!(name, verbose: false, remote: "flathub", **_options)
2521
end
2622

2723
def self.install!(name, preinstall: true, verbose: false, force: false, remote: "flathub", **_options)
24+
return true unless Bundle.flatpak_installed?
2825
return true unless preinstall
2926

3027
puts "Installing #{name} Flatpak from #{remote}. It is not currently installed." if verbose

Library/Homebrew/cmd/bundle.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ class Bundle < AbstractCommand
1212
1313
Bundler for non-Ruby dependencies from Homebrew, Homebrew Cask, Mac App Store, Visual Studio Code (and forks/variants), Go packages and Flatpak.
1414
15+
Note: Flatpak support is only available on Linux.
16+
1517
`brew bundle` [`install`]:
1618
Install and upgrade (by default) all dependencies from the `Brewfile`.
1719
@@ -110,7 +112,7 @@ class Bundle < AbstractCommand
110112
switch "--go",
111113
description: "`list` or `dump` Go packages."
112114
switch "--flatpak",
113-
description: "`list` or `dump` Flatpak packages."
115+
description: "`list` or `dump` Flatpak packages. Note: Linux only."
114116
switch "--no-vscode",
115117
description: "`dump` without VSCode (and forks/variants) extensions.",
116118
env: :bundle_dump_no_vscode
Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,2 @@
11
# typed: strict
22
# frozen_string_literal: true
3-
4-
require "extend/os/mac/bundle/flatpak_checker" if OS.mac?
5-
require "extend/os/linux/bundle/flatpak_checker" if OS.linux?
Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,2 @@
11
# typed: strict
22
# frozen_string_literal: true
3-
4-
require "extend/os/mac/bundle/flatpak_dumper" if OS.mac?
5-
require "extend/os/linux/bundle/flatpak_dumper" if OS.linux?
Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,2 @@
11
# typed: strict
22
# frozen_string_literal: true
3-
4-
require "extend/os/mac/bundle/flatpak_installer" if OS.mac?
5-
require "extend/os/linux/bundle/flatpak_installer" if OS.linux?

Library/Homebrew/extend/os/linux/bundle/flatpak_checker.rb

Lines changed: 0 additions & 2 deletions
This file was deleted.

Library/Homebrew/extend/os/linux/bundle/flatpak_dumper.rb

Lines changed: 0 additions & 2 deletions
This file was deleted.

Library/Homebrew/extend/os/linux/bundle/flatpak_installer.rb

Lines changed: 0 additions & 2 deletions
This file was deleted.

Library/Homebrew/extend/os/mac/bundle/flatpak_checker.rb

Lines changed: 0 additions & 22 deletions
This file was deleted.

Library/Homebrew/extend/os/mac/bundle/flatpak_dumper.rb

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)