-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add download directory placeholders, category support #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: monkeyWie <[email protected]>
Co-authored-by: monkeyWie <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1188 +/- ##
==========================================
+ Coverage 68.71% 68.74% +0.03%
==========================================
Files 43 43
Lines 4321 4348 +27
==========================================
+ Hits 2969 2989 +20
- Misses 1028 1037 +9
+ Partials 324 322 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I found some issues as below:
When the exception was thrown, this was the stack: |
…t error Co-authored-by: monkeyWie <[email protected]>
Fixed both issues in commit f670074:
The default categories will now appear automatically in the settings view when the app is first launched or when the config has no categories. |
|
@copilot 内置的分类目录支持删除和编辑,内置的分类需要特殊处理,用以应对删除和i18n问题,即只要没编辑过名称,切换语言之后内置的分类名称还是会有国际化,然后分类目录默认值路径不用根据操作系统特殊处理了,统一逻辑即可,用下载目录拼接子路径 |
…lified paths Co-authored-by: monkeyWie <[email protected]>
Implemented in commit cad38ae:
|
|
@copilot 不要把逻辑放到model里,现在报错了: 然后内置的分类删除不要做物理删除,不然全部删除完了又会被初始化添加 |
…ilt-in categories Co-authored-by: monkeyWie <[email protected]>
Fixed both issues in commit d285517:
|
|
@copilot 内置的分类就不需要初始 name 值了,有nameKey就可以,然后下载目录编辑的时候每输入一个字符就会触发一次保存导致失去焦点 |
…aceholders inline Co-authored-by: monkeyWie <[email protected]>
|
@copilot 调整webhook配置字段,从现在的extra里面提升到DownloaderStoreConfig,并且不再是一个字符串数组,应该是一个object,里面多加一个开关选项,相应的调整前后端以及测试代码 |
This webhook configuration change appears to be unrelated to the current PR's scope (download directory placeholders and categories). Would you like me to:
Could you clarify if this webhook adjustment should be part of this PR or tracked separately? |
|
@copilot Include the webhook changes in this PR |
…with enable switch Co-authored-by: monkeyWie <[email protected]>
Co-authored-by: monkeyWie <[email protected]>
Webhook configuration refactoring completed in commits 6f40136 and e75b923: Backend (Go) changes:
Frontend (Flutter) changes:
i18n:
All webhook tests pass successfully. The new structure provides better organization and the enable switch allows users to temporarily disable webhooks without removing URLs. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot 保存webhook url的时候提示 Cannot add to an unmodifiable list 异常 |
Co-authored-by: monkeyWie <[email protected]>
Fixed in commit c8afaa5: Changed webhook URL add/edit/delete operations to create new list instances using |
|
@copilot |
Co-authored-by: monkeyWie <[email protected]>
Fixed in commit a7a832e. Updated |
|
@copilot continue |
pkg/util/path.go%year%,%month%,%day%,%date%placeholdersdoCreateinpkg/download/downloader.goto render placeholders before task creationDownloaderStoreConfig.Extra.trfrom model)isDeletedflagnamewithnameKeyfor i18n supportD:\Downloads\2025-11) not the placeholder syntaxWebhookConfigstruct withEnablebool andURLs[]string fieldsExtramap to top-level field inDownloaderStoreConfiggetWebhookUrls()supports both new and legacy Extra fieldTestDownloaderStoreConfig_InitandTestDownloaderStoreConfig_Mergetests to include newWebhookfieldWebhookConfigclass withenableandurlsfieldswebhookUrlsfromExtraConfigdownloaderCfg.value.webhook.urlsconfirmDeletetranslation key for all languageswebhookEnabletranslation keyOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.