`ggshield scan docker` fails with missing path error when run from the Docker image

[cdupuis]

Environment

• ggshield version: gitguardian/ggshield:latest
• Operating system (Linux, macOS, Windows):
• Operating system version:
• Python version:

Describe the bug

I expect the following command to not fail:

❯ docker run -it -v /var/run/docker.sock:/var/run/docker.sock -e GITGUARDIAN_API_KEY=${GITGUARDIAN_API_KEY} gitguardian/ggshield ggshield secret scan docker alpine
Saving docker image...
Error: [Errno 2] No such file or directory: 'docker'

Re-run the command with --verbose to get a stack trace.

[fnareoh]

Hi, thank you for creating this issue.
I believe this is due to the docker command not being available inside your docker.
The error occurs when trying to run this command to download the docker image alpine, but we will improve the error by catching it and printing something more explicit. 😄

[cdupuis]

I believe this is due to the docker command not being available inside your docker.

This is your official Docker image, not my image. So shouldn't you add the Docker CLI to the ggshield image in that case to make this error disappear?

[fnareoh]

Ah yes sorry I got confused, yes we will !

[cdupuis]

I can confirm that running ggshield from an image built from the following Dockerfile works as expected:

FROM gitguardian/ggshield:latest

RUN \
    apt-get update \
    && apt-get install -y --no-install-recommends ca-certificates curl gnupg \
    && apt-get clean \
    && rm -rf /var/lib/apt/lists/* \
    && curl -fsSL https://get.docker.com | sh

[fnareoh]

Thanks a lot 🙏 , I doubled checked and opened a PR. We will just wait for the return of @agateau-gg (our main maintainer, returning probably next Wednesday) to validate !