Skip to content

Conversation

@DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Nov 29, 2025

Summary

Addressing the theme aspect of #6976

Changes

  • What: Not comprehensive, but swaps many of the colors in the litegraph panel styles to reference theme tokens.

Screenshots (if applicable)

image image

┆Issue is synchronized with this Notion page by Unito

@DrJKL DrJKL requested a review from a team as a code owner November 29, 2025 02:45
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 29, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 29, 2025

📝 Walkthrough

Walkthrough

Converts hard-coded colors and many !important rules to CSS variables, updating litegraph and design-system styles to use tokenized colors, font declarations, and normalized specificity without behavioral changes.

Changes

Cohort / File(s) Summary
CSS theming & specificity refactor
src/lib/litegraph/public/css/litegraph.css, packages/design-system/src/css/style.css
Replaced explicit color literals and removed many !important overrides in favor of CSS variables (e.g., var(--border-default), var(--comfy-menu-bg), var(--content-hover-fg)). Updated dialog/panel/menu/button/input selectors and font declarations to rely on variable-based tokens and standard cascade specificity.

Possibly related PRs

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch drjkl/properties-theme

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0122e5 and 0580ac6.

📒 Files selected for processing (2)
  • packages/design-system/src/css/style.css (2 hunks)
  • src/lib/litegraph/public/css/litegraph.css (14 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/lib/litegraph/public/css/litegraph.css
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package

Applied to files:

  • packages/design-system/src/css/style.css
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: setup
  • GitHub Check: test
  • GitHub Check: lint-and-format
🔇 Additional comments (5)
packages/design-system/src/css/style.css (5)

1190-1194: Theme token applied correctly for context menu background.

The change to var(--comfy-menu-bg) is appropriate and will automatically adapt to light/dark themes via the theme tokens defined in :root and .dark-theme sections.


1197-1201: Submenu styling properly tokenized with correct contrast tokens.

Both background and text color now reference appropriate theme variables that support light/dark modes. The previous semicolon issue has been resolved.


1203-1206: Input styling uses consistent design system tokens.

The use of --comfy-input-bg and --input-text aligns with input styling patterns elsewhere in the stylesheet and ensures theme consistency.


1244-1249: Search box background properly themed.

Using --comfy-menu-bg maintains visual consistency with the context menu component and ensures automatic theme adaptation.


1251-1255: Search input/select elements use consistent input tokens.

The change maintains consistency with input styling patterns throughout the design system and ensures theme support.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 29, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 11/29/2025, 10:02:41 AM UTC

📈 Summary

  • Total Tests: 496
  • Passed: 485 ✅
  • Failed: 0
  • Flaky: 2 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 476 / ❌ 0 / ⚠️ 2 / ⏭️ 9
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Nov 29, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 11/29/2025, 09:53:17 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Nov 29, 2025

Bundle Size Report

Summary

  • Raw size: 17 MB baseline 17 MB — ⚪ 0 B
  • Gzip: 3.37 MB baseline 3.37 MB — 🔴 +6 B
  • Brotli: 2.58 MB baseline 2.58 MB — 🟢 -133 B
  • Bundles: 97 current • 97 baseline • 36 added / 36 removed

Category Glance
Vendor & Third-Party ⚪ 0 B (8.56 MB) · Other ⚪ 0 B (3.84 MB) · App Entry Points ⚪ 0 B (3.18 MB) · Graph Workspace ⚪ 0 B (949 kB) · Panels & Settings ⚪ 0 B (298 kB) · UI Components ⚪ 0 B (139 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.18 MB (baseline 3.18 MB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-BaIAwWq_.js (removed) 2.95 MB 🟢 -2.95 MB 🟢 -615 kB 🟢 -467 kB
assets/index-BGJW32uX.js (new) 2.95 MB 🔴 +2.95 MB 🔴 +615 kB 🔴 +467 kB
assets/index-CwfkVyor.js (removed) 227 kB 🟢 -227 kB 🟢 -48.6 kB 🟢 -40 kB
assets/index-DMbXRBy7.js (new) 227 kB 🔴 +227 kB 🔴 +48.6 kB 🔴 +40 kB
assets/index-CRxqr6ze.js (new) 345 B 🔴 +345 B 🔴 +245 B 🔴 +235 B
assets/index-i47K8MSK.js (removed) 345 B 🟢 -345 B 🟢 -247 B 🟢 -202 B

Status: 3 added / 3 removed

Graph Workspace — 949 kB (baseline 949 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-S1JZi48B.js (removed) 949 kB 🟢 -949 kB 🟢 -184 kB 🟢 -141 kB
assets/GraphView-tIyVzutY.js (new) 949 kB 🔴 +949 kB 🔴 +184 kB 🔴 +141 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-B0E0nQXr.js (removed) 6.54 kB 🟢 -6.54 kB 🟢 -2.14 kB 🟢 -1.9 kB
assets/UserSelectView-DBLMbDbx.js (new) 6.54 kB 🔴 +6.54 kB 🔴 +2.14 kB 🔴 +1.9 kB

Status: 1 added / 1 removed

Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CreditsPanel-DuQRzffH.js (new) 21.4 kB 🔴 +21.4 kB 🔴 +5.15 kB 🔴 +4.5 kB
assets/CreditsPanel-FOG1Bfds.js (removed) 21.4 kB 🟢 -21.4 kB 🟢 -5.15 kB 🟢 -4.5 kB
assets/KeybindingPanel-ChJAkqX7.js (removed) 13.6 kB 🟢 -13.6 kB 🟢 -3.42 kB 🟢 -3.01 kB
assets/KeybindingPanel-gyRvKSWz.js (new) 13.6 kB 🔴 +13.6 kB 🔴 +3.42 kB 🔴 +3.01 kB
assets/ExtensionPanel-BvKPkyWC.js (new) 10.8 kB 🔴 +10.8 kB 🔴 +2.57 kB 🔴 +2.25 kB
assets/ExtensionPanel-CJ6MAKHf.js (removed) 10.8 kB 🟢 -10.8 kB 🟢 -2.57 kB 🟢 -2.25 kB
assets/AboutPanel-BWw5-Y-V.js (new) 9.16 kB 🔴 +9.16 kB 🔴 +2.46 kB 🔴 +2.21 kB
assets/AboutPanel-CZ6vni3M.js (removed) 9.16 kB 🟢 -9.16 kB 🟢 -2.46 kB 🟢 -2.21 kB
assets/ServerConfigPanel-7YdA7IjW.js (removed) 6.56 kB 🟢 -6.56 kB 🟢 -1.83 kB 🟢 -1.62 kB
assets/ServerConfigPanel-DxOU0RX1.js (new) 6.56 kB 🔴 +6.56 kB 🔴 +1.83 kB 🔴 +1.63 kB
assets/UserPanel-ByIMnEz0.js (removed) 6.23 kB 🟢 -6.23 kB 🟢 -1.72 kB 🟢 -1.52 kB
assets/UserPanel-LL_JQUOX.js (new) 6.23 kB 🔴 +6.23 kB 🔴 +1.72 kB 🔴 +1.51 kB
assets/settings-BhbWhsRg.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BXTtSH4O.js 33.3 kB 33.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-C9Pzn-NG.js 25.2 kB 25.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CCy2fA_h.js 27.3 kB 27.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CQpqEFfl.js 26.6 kB 26.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DHcnxypw.js 21.7 kB 21.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DhFTK9fY.js 25.1 kB 25.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DlT4t_ui.js 25.9 kB 25.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DRgSrIdD.js 24.2 kB 24.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-tjkeqiZq.js 21.1 kB 21.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 139 kB (baseline 139 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-BeR5XEYE.js (new) 53.9 kB 🔴 +53.9 kB 🔴 +8.52 kB 🔴 +7.31 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-DSWOEFJB.js (removed) 53.9 kB 🟢 -53.9 kB 🟢 -8.52 kB 🟢 -7.31 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-CU84GK8X.js (new) 47 kB 🔴 +47 kB 🔴 +10.1 kB 🔴 +8.78 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-DUwIwQBq.js (removed) 47 kB 🟢 -47 kB 🟢 -10.1 kB 🟢 -8.78 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-akAeHUog.js (removed) 12.8 kB 🟢 -12.8 kB 🟢 -3.35 kB 🟢 -2.96 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-Dm_6Nlvt.js (new) 12.8 kB 🔴 +12.8 kB 🔴 +3.35 kB 🔴 +2.95 kB
assets/ComfyQueueButton-CAT4mtx_.js (new) 8.44 kB 🔴 +8.44 kB 🔴 +2.48 kB 🔴 +2.21 kB
assets/ComfyQueueButton-CIzFa9z8.js (removed) 8.44 kB 🟢 -8.44 kB 🟢 -2.48 kB 🟢 -2.21 kB
assets/MediaTitle.vue_vue_type_script_setup_true_lang-CKVecD6A.js (new) 897 B 🔴 +897 B 🔴 +503 B 🔴 +463 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-CtAMGEIT.js (removed) 897 B 🟢 -897 B 🟢 -504 B 🟢 -429 B
assets/LazyImage.vue_vue_type_script_setup_true_lang-Pm3jgX4e.js 10.8 kB 10.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-Bs-EIQeq.js 1.34 kB 1.34 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetButton-CsMa_P26.js 2.04 kB 2.04 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-Cf8dNyi2.js 2 kB 2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 5 added / 5 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-B4YS611n.js (new) 7.51 kB 🔴 +7.51 kB 🔴 +1.84 kB 🔴 +1.58 kB
assets/keybindingService-CchRYcle.js (removed) 7.51 kB 🟢 -7.51 kB 🟢 -1.83 kB 🟢 -1.58 kB
assets/audioService-BiMPzf0O.js (removed) 2.2 kB 🟢 -2.2 kB 🟢 -959 B 🟢 -823 B
assets/audioService-DruczXVg.js (new) 2.2 kB 🔴 +2.2 kB 🔴 +960 B 🔴 +828 B
assets/serverConfigStore-B5NW8oSr.js 2.83 kB 2.83 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/audioUtils-Bw6F1MDV.js (removed) 1.41 kB 🟢 -1.41 kB 🟢 -652 B 🟢 -550 B
assets/audioUtils-WDoNJWCG.js (new) 1.41 kB 🔴 +1.41 kB 🔴 +652 B 🔴 +548 B
assets/mathUtil-CTARWQ-l.js 1.07 kB 1.07 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeFilterUtil-CXKCRJ-m.js 460 B 460 B ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-chart-uhYFfslB.js 452 kB 452 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-other-DisjWJFj.js 3.98 MB 3.98 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-LncEKxae.js 1.96 MB 1.96 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-aR6ntw5X.js 1.37 MB 1.37 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-C4yk8cCR.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-tw3tq7KH.js 160 kB 160 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BZLod3g9.js 407 kB 407 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 3.84 MB (baseline 3.84 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/WidgetRecordAudio-_BGPiv3A.js (removed) 20.4 kB 🟢 -20.4 kB 🟢 -5.24 kB 🟢 -4.64 kB
assets/WidgetRecordAudio-CID7yucf.js (new) 20.4 kB 🔴 +20.4 kB 🔴 +5.24 kB 🔴 +4.63 kB
assets/AudioPreviewPlayer-B-JNrQbn.js (new) 13.5 kB 🔴 +13.5 kB 🔴 +3.4 kB 🔴 +3.04 kB
assets/AudioPreviewPlayer-DF7QB_MQ.js (removed) 13.5 kB 🟢 -13.5 kB 🟢 -3.4 kB 🟢 -3.04 kB
assets/WidgetGalleria-D9b-vYZu.js (new) 4.1 kB 🔴 +4.1 kB 🔴 +1.45 kB 🔴 +1.3 kB
assets/WidgetGalleria-wxuh6lR8.js (removed) 4.1 kB 🟢 -4.1 kB 🟢 -1.45 kB 🟢 -1.3 kB
assets/WidgetColorPicker-BNygPrc4.js (new) 3.41 kB 🔴 +3.41 kB 🔴 +1.38 kB 🔴 +1.23 kB
assets/WidgetColorPicker-CJpdHTbO.js (removed) 3.41 kB 🟢 -3.41 kB 🟢 -1.38 kB 🟢 -1.23 kB
assets/WidgetMarkdown-CpvQ_ZBb.js (new) 3.1 kB 🔴 +3.1 kB 🔴 +1.29 kB 🔴 +1.13 kB
assets/WidgetMarkdown-D4PNapCQ.js (removed) 3.1 kB 🟢 -3.1 kB 🟢 -1.29 kB 🟢 -1.13 kB
assets/WidgetAudioUI-BpmJnqFZ.js (removed) 2.82 kB 🟢 -2.82 kB 🟢 -1.12 kB 🟢 -1.02 kB
assets/WidgetAudioUI-BPraVrBj.js (new) 2.82 kB 🔴 +2.82 kB 🔴 +1.12 kB 🔴 +1.02 kB
assets/WidgetTextarea-BmuXSLjd.js (removed) 2.48 kB 🟢 -2.48 kB 🟢 -1.01 kB 🟢 -900 B
assets/WidgetTextarea-CNlLOVCn.js (new) 2.48 kB 🔴 +2.48 kB 🔴 +1.01 kB 🔴 +886 B
assets/WidgetInputText-Dd1116ep.js (removed) 1.99 kB 🟢 -1.99 kB 🟢 -918 B 🟢 -845 B
assets/WidgetInputText-GHIkIMpy.js (new) 1.99 kB 🔴 +1.99 kB 🔴 +918 B 🔴 +853 B
assets/MediaImageBottom-a6RKj2SU.js (new) 1.57 kB 🔴 +1.57 kB 🔴 +744 B 🔴 +642 B
assets/MediaImageBottom-Dze5Q59G.js (removed) 1.57 kB 🟢 -1.57 kB 🟢 -741 B 🟢 -642 B
assets/MediaAudioBottom-3q-p7XTR.js (new) 1.52 kB 🔴 +1.52 kB 🔴 +741 B 🔴 +653 B
assets/MediaAudioBottom-DK6LbcyF.js (removed) 1.52 kB 🟢 -1.52 kB 🟢 -743 B 🟢 -654 B
assets/MediaVideoBottom-D8lM5FnH.js (new) 1.52 kB 🔴 +1.52 kB 🔴 +740 B 🔴 +653 B
assets/MediaVideoBottom-psm2uv7r.js (removed) 1.52 kB 🟢 -1.52 kB 🟢 -738 B 🟢 -652 B
assets/Media3DBottom-BwqtZQoo.js (removed) 1.5 kB 🟢 -1.5 kB 🟢 -732 B 🟢 -649 B
assets/Media3DBottom-htpI_Xik.js (new) 1.5 kB 🔴 +1.5 kB 🔴 +733 B 🔴 +648 B
assets/Media3DTop-CbHse8O4.js (new) 1.49 kB 🔴 +1.49 kB 🔴 +764 B 🔴 +655 B
assets/Media3DTop-D2IaaD1x.js (removed) 1.49 kB 🟢 -1.49 kB 🟢 -765 B 🟢 -649 B
assets/WidgetSelect-C7zIioLp.js (removed) 655 B 🟢 -655 B 🟢 -343 B 🟢 -306 B
assets/WidgetSelect-C993vxAy.js (new) 655 B 🔴 +655 B 🔴 +343 B 🔴 +288 B
assets/WidgetInputNumber-Bu6z2NuJ.js (new) 595 B 🔴 +595 B 🔴 +329 B 🔴 +274 B
assets/WidgetInputNumber-lBYQz7IE.js (removed) 595 B 🟢 -595 B 🟢 -330 B 🟢 -276 B
assets/Load3D-CDK7qIaS.js (removed) 424 B 🟢 -424 B 🟢 -269 B 🟢 -224 B
assets/Load3D-KnH4b27n.js (new) 424 B 🔴 +424 B 🔴 +267 B 🔴 +223 B
assets/WidgetLegacy-B-WrNnRO.js (new) 364 B 🔴 +364 B 🔴 +236 B 🔴 +193 B
assets/WidgetLegacy-B9V2d40_.js (removed) 364 B 🟢 -364 B 🟢 -236 B 🟢 -195 B
assets/commands-_s-RvhJR.js 13.6 kB 13.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BuUILW6P.js 13 kB 13 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BV4R6fLx.js 14.9 kB 14.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BWp4HdfU.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CLwPdnT6.js 14.2 kB 14.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CWMchBmd.js 15.9 kB 15.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DazTQhtc.js 12.9 kB 12.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DmWrOe93.js 13.7 kB 13.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwiH7Kr6.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-mS3LCNPn.js 14.5 kB 14.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-5lOBdqcC.js 84.5 kB 84.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BOCuaVpE.js 73.4 kB 73.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-ClrEFGUz.js 72.4 kB 72.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Cw9RZWRY.js 89 B 89 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CyNU0iQX.js 99.3 kB 99.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-D7gwLxft.js 114 kB 114 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DC8o4BCt.js 86.8 kB 86.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DKiesCV4.js 94.3 kB 94.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Hq2q-OtB.js 83.6 kB 83.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-USAlAlnj.js 82 kB 82 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaAudioTop-Bqc4HR5L.js 1.46 kB 1.46 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaImageTop-DbyT2UjV.js 1.75 kB 1.75 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaVideoTop-6PQqfKb3.js 2.76 kB 2.76 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-_Px5dSNW.js 306 kB 306 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-7z21KPoS.js 285 kB 285 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BWKZzBPK.js 346 kB 346 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CGbgH4Yl.js 320 kB 320 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CjjjdWkV.js 313 kB 313 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CVrNtxvj.js 288 kB 288 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DLRSA0IK.js 309 kB 309 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DQV2gnwA.js 372 kB 372 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-ofqLG5vz.js 310 kB 310 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetChart-C9sMH5oS.js 2.48 kB 2.48 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetImageCompare-D4gTOuOo.js 2.21 kB 2.21 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js 1.28 kB 1.28 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetToggleSwitch-CBRsIck7.js 1.58 kB 1.58 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 17 added / 17 removed

@DrJKL DrJKL mentioned this pull request Nov 29, 2025
3 tasks
@DragonDiffusionbyBoyo
Copy link

the images look good, this should resolve my issues.

@DrJKL DrJKL added the New Browser Test Expectations New browser test screenshot should be set by github action label Nov 29, 2025
@github-actions
Copy link

Updating Playwright Expectations

@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Nov 29, 2025
@DrJKL DrJKL added the New Browser Test Expectations New browser test screenshot should be set by github action label Nov 29, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/lib/litegraph/public/css/litegraph.css (1)

413-430: I'll verify the CSS variable definitions to confirm whether --text-foreground is actually undefined and identify the correct token to use.
<function_calls>


#!/bin/bash

First, let's find the design-system style.css file

echo "=== Finding design-system style.css ==="
find . -name "style.css" -type f | head -20

echo ""
echo "=== Looking for design-system package ==="
find . -type d -name "design-system" | head -10


</function_calls>

Let me get the content of the design-system CSS file to check available variables:
<function_calls>


#!/bin/bash

Check the design-system style.css file

if [ -f "packages/design-system/src/css/style.css" ]; then
echo "=== Content of packages/design-system/src/css/style.css ==="
wc -l "packages/design-system/src/css/style.css"
echo ""

Show the file with line numbers (limiting to reasonable size)

cat -n "packages/design-system/src/css/style.css" | head -100
else
echo "File not found at packages/design-system/src/css/style.css"
ls -la packages/design-system/src/css/ 2>/dev/null || echo "Directory doesn't exist"
fi


</function_calls>

Now let me check the litegraph.css file to see how it uses CSS variables and search for any definitions:
<function_calls>


#!/bin/bash

echo "=== Checking litegraph.css file size and content ==="
wc -l "src/lib/litegraph/public/css/litegraph.css"

echo ""
echo "=== Lines 410-435 of litegraph.css (context around the issue) ==="
sed -n '410,435p' "src/lib/litegraph/public/css/litegraph.css" | cat -n

echo ""
echo "=== Searching for --text-foreground definition/usage in litegraph.css ==="
grep -n "--text-foreground" "src/lib/litegraph/public/css/litegraph.css"

echo ""
echo "=== Searching for CSS variable definitions in litegraph.css ==="
grep -n "^\s*--" "src/lib/litegraph/public/css/litegraph.css" | head -30


</function_calls>

Let me search across the codebase for where --text-foreground might be defined:
<function_calls>


#!/bin/bash

echo "=== Searching for --text-foreground definition anywhere ==="
rg "--text-foreground" -n --type css

echo ""
echo "=== Searching for available foreground variables ==="
rg "--.*foreground" -n --type css | head -30

echo ""
echo "=== Searching for text color related variables ==="
rg "--text-" -n --type css | head -30


</function_calls>

Now let me check what CSS variables are actually defined in the design-system package and see the full style.css:
<function_calls>


#!/bin/bash

echo "=== Full content of design-system style.css ==="
cat -n "packages/design-system/src/css/style.css"


</function_calls>

Let me also check if there are any root CSS variables or if litegraph.css defines its own tokens:
<function_calls>


#!/bin/bash

echo "=== Searching for CSS variable definitions (--) in litegraph.css ==="
rg "^\s*--" "src/lib/litegraph/public/css/litegraph.css" -n

echo ""
echo "=== Checking for :root or html selector with variables ==="
rg -A 20 "^\s*(:root|html)\s*{" "src/lib/litegraph/public/css/litegraph.css"

echo ""
echo "=== Full content of litegraph.css to understand variable context ==="
cat -n "src/lib/litegraph/public/css/litegraph.css"


</function_calls>

Now let me check how other parts of the codebase handle text color for buttons and similar elements:
<function_calls>


#!/bin/bash

echo "=== Searching for button styles in other CSS files ==="
rg ".btn|button" --type css -A 3 -B 1 | grep -E "(.btn|button|color|--)" | head -40

echo ""
echo "=== Searching for --base-foreground usage ==="
rg "--base-foreground" -n --type css

echo ""
echo "=== Searching for color variables defined ==="
rg ":\s*var(--.*color" --type css | head -30


</function_calls>

Let me get a comprehensive view of all CSS variables used in the repository:
<function_calls>


#!/bin/bash

echo "=== All CSS variable references in entire codebase ==="
rg "var(--[a-zA-Z0-9-]+)" --type css -o -h | sort | uniq | head -50


</function_calls>

Let me search for where CSS variables are imported or included in the litegraph context:
<function_calls>


#!/bin/bash

echo "=== Check if litegraph.css imports or references design-system CSS ==="
head -50 "src/lib/litegraph/public/css/litegraph.css"

echo ""
echo "=== Check for @import statements ==="
rg "@import" "src/lib/litegraph/public/css/litegraph.css"

echo ""
echo "=== Look for how litegraph.css is used in the project ==="
rg "litegraph.css" --type html --type js --type ts -B 2 -A 2 | head -40


</function_calls>

Now let me check the actual HTML/component files that use litegraph to understand the CSS variable scope:
<function_calls>


#!/bin/bash

echo "=== Files that import or reference litegraph ==="
rg "litegraph" --type ts --type js --type vue -l | head -10

echo ""
echo "=== Check main entry points or layout files ==="
find . -name "App.vue" -o -name "app.html" -o -name "index.html" -o -name "main.css" 2>/dev/null | head -10


</function_calls>

Let me check what the actual design-system variables are:
<function_calls>


#!/bin/bash

echo "=== Extract all CSS variable definitions from design-system ==="
rg "^\s*--" "packages/design-system/src/css/style.css" -o | sort | uniq

echo ""
echo "=== Look for text or foreground related variables specifically ==="
rg "(text|foreground|color)" "packages/design-system/src/css/style.css" -i | grep "^\s*--"


</function_calls>

Let me check if there's a root CSS file that applies these variables globally:
<function_calls>


#!/bin/bash

echo "=== Looking for global CSS or root variable definitions ==="
find . -name ".css" -type f | xargs grep -l "^\s:root|^\shtml\s{" | head -10

echo ""
echo "=== Check app layout or main CSS files ==="
find src -name "*.css" -type f | head -20

echo ""
echo "=== Check if style.css from design-system is imported anywhere ==="
rg "design-system.*style.css|from.*style.css" -B 2 -A 2 | head -40


</function_calls>

Let me examine the exact structure and find where CSS variables are actually defined:
<function_calls>


#!/bin/bash

echo "=== Get complete design-system style.css file ==="
if [ -f "packages/design-system/src/css/style.css" ]; then
cat "packages/design-system/src/css/style.css"
else
echo "File not found"
ls -R packages/design-system/src/css/ 2>/dev/null || echo "Directory structure not found"
fi

echo ""
echo "=== Look for all CSS files in packages/design-system ==="
find packages/design-system -name "*.css" -type f 2>/dev/null


</function_calls>

Let me try a different approach - check the repository structure more broadly:
<function_calls>


#!/bin/bash

echo "=== Check if packages directory exists ==="
ls -la packages/ 2>/dev/null | head -20

echo ""
echo "=== Check for design-system package ==="
if [ -d "packages/design-system" ]; then
find "packages/design-system" -type f -name ".css" -o -name ".ts" -o -name ".js" | head -20
else
echo "packages/design-system not found - searching for design-system anywhere"
find . -type d -name "designsystem
" 2>/dev/null
fi


</function_calls>

Let me examine the actual litegraph.css file completely and check for variable definitions:
<function_calls>


#!/bin/bash

echo "=== Complete litegraph.css file ==="
cat "src/lib/litegraph/public/css/litegraph.css"


</function_calls>

<function_calls>


#!/bin/bash

echo "=== Check repository root structure ==="
ls -la | head -30

echo ""
echo "=== Check if packages directory exists and what's in it ==="
ls -la packages/ 2>/dev/null || echo "No packages directory at root"

echo ""
echo "=== Check package.json for dependencies ==="
if [ -f "package.json" ]; then
head -50 package.json
else
echo "No package.json at root"
fi

echo ""
echo "=== Look for any style or CSS configuration ==="
find . -maxdepth 2 -name ".json" -o -name ".config.*" 2>/dev/null | grep -E "(style|css|config)" | head -10


</function_calls>

Based on the shell script outputs, let me now verify whether --text-foreground is actually defined somewhere or used in the codebase:
<function_calls>


#!/bin/bash

echo "=== Search for --text-foreground definition in entire repo ==="
rg "--text-foreground\s*:" --type css

echo ""
echo "=== Search for any definition or assignment of --text-foreground ==="
rg "--text-foreground" -B 2 -A 2

echo ""
echo "=== Look for similar variable patterns in litegraph or globally ==="
rg "color\s*:\s*var(--" --type css -o -h | sort | uniq | head -20


</function_calls>

Now let me verify what happens when CSS variables are undefined and check if there are fallback colors or defaults:
<function_calls>


#!/bin/bash

echo "=== Check for any CSS variable fallbacks in litegraph.css ==="
rg "var(--.,\s" "src/lib/litegraph/public/css/litegraph.css"

echo ""
echo "=== Extract all var() usages with context ==="
rg "var(--[^)]+)" "src/lib/litegraph/public/css/litegraph.css" -o | sort | uniq

echo ""
echo "=== Check lines 413-430 with full context ==="
sed -n '410,435p' "src/lib/litegraph/public/css/litegraph.css"


</function_calls>

Let me look at what CSS variables are actually available in the frontend styles:
<function_calls>


#!/bin/bash

echo "=== Find all CSS files in src/ ==="
find src -name "*.css" -type f

echo ""
echo "=== Search for CSS variable definitions in any CSS file ==="
rg "^\s*--[a-zA-Z]+" --type css -o -h | sort | uniq | head -50


</function_calls>

Let me check if there's a theme or global styles file that defines these variables:
<function_calls>


#!/bin/bash

echo "=== Look for theme or global style definitions ==="
find src -type f ( -name "theme" -o -name "global" -o -name "root" ) 2>/dev/null

echo ""
echo "=== Check for CSS modules or variable exports ==="
rg "export.*--" --type css

echo ""
echo "=== Look for :root selector definitions ==="
rg -A 50 "^\s*:root\s*{" --type css | head -80


</function_calls>

Let me get the git history or PR information to understand what changes were made:
<function_calls>


#!/bin/bash

echo "=== Check git diff for the litegraph.css file ==="
git diff HEAD -- "src/lib/litegraph/public/css/litegraph.css" 2>/dev/null | head -100

echo ""
echo "=== Check git log for recent changes ==="
git log --oneline -10 -- "src/lib/litegraph/public/css/litegraph.css" 2>/dev/null

echo ""
echo "=== Check git status ==="
git status 2>/dev/null | head -20


</function_calls>

Let me now run a comprehensive analysis to list all CSS variables defined in the entire codebase:
<function_calls>


#!/bin/bash

echo "=== Extract ALL CSS variable definitions (--name: value) ==="
rg "^\s*--[a-zA-Z0-9-]+\s*:" --type css -A 0 -B 0 | sort | uniq

echo ""
echo "=== Specifically search for foreground-related variables ==="
rg "(foreground|text.*color|color.text)" --type css -i | grep "^\s--" | head -20


</function_calls>

Let me check the Vue/TypeScript files to see if they define CSS variables dynamically:
<function_calls>


#!/bin/bash

echo "=== Search for CSS variable definitions in Vue/TS files ==="
rg "setProperty.*--" --type ts --type js --type vue

echo ""
echo "=== Look for style definitions in Vue components ==="
rg "<style" --type vue -A 20 | grep -E "(style|--)" | head -30

echo ""
echo "=== Check for Tailwind or other CSS framework config ==="
find . -maxdepth 2 -name "tailwind.config." -o -name ".postcssrc."


</function_calls>

Let me verify if --text-foreground is used anywhere besides the flagged lines:
<function_calls>


#!/bin/bash

echo "=== Search for --text-foreground in entire codebase ==="
rg "--text-foreground" -B 2 -A 2

echo ""
echo "=== Count occurrences of --text-foreground ==="
rg "--text-foreground" -c --type-list | awk '{s+=$1} END {print "Total occurrences:", s}'

echo ""
echo "=== Check what other color variables exist similar to this pattern ==="
rg "--(text|color|foreground)" --type css -o | sort | uniq | head -40


</function_calls>

Let me check if there's a CSS root definition somewhere that I might have missed:
<function_calls>


#!/bin/bash

echo "=== Find all CSS with potential variable definitions ==="
find . -name "*.css" -type f -exec grep -l "--" {} ;

echo ""
echo "=== Show complete content of main CSS files ==="
for file in $(find src -name "*.css" -type f); do
echo "=== FILE: $file ==="
cat "$file"
echo ""
done


</function_calls>

<function_calls>


#!/bin/bash

echo "=== Comprehensive search: list ALL CSS files and their CSS variable content ==="
echo "Total CSS files found:"
find . -name "*.css" -type f | wc -l

echo ""
echo "=== Check each CSS file for variable definitions ==="
for file in $(find . -name ".css" -type f); do
varcount=$(grep -c "^\s
--" "$file" 2>/dev/null || echo 0)
if [ "$varcount" -gt 0 ]; then
echo "$file: $varcount variables"
grep "^\s*--" "$file" | head -5
echo ""
fi
done


</function_calls>

Now let me check the specific question: are these CSS variables supposed to be inherited/cascaded from somewhere?
<function_calls>


#!/bin/bash

echo "=== Check how litegraph CSS file is loaded - check HTML/Vue imports ==="
rg "litegraph.css" -B 3 -A 3

echo ""
echo "=== Look for component that uses litegraph classes ==="
rg "litegraph" --type vue -l | head -5

if [ -n "$(rg 'litegraph' --type vue -l | head -1)" ]; then
echo ""
echo "=== Content of first litegraph Vue component ==="
vue_file=$(rg 'litegraph' --type vue -l | head -1)
cat "$vue_file" | head -100
fi


</function_calls>

Let me also check if there's any initialization or setup that provides these CSS variables:
<function_calls>


#!/bin/bash

echo "=== Check main.ts or app initialization ==="
find src -name "main.ts" -o -name "main.js" -o -name "app.ts" | xargs cat 2>/dev/null | head -50

echo ""
echo "=== Look for any style injection or CSS setup ==="
rg "style|css|theme" --type ts --type js | grep -E "(import|require|setup)" | head -20


</function_calls>

Let me take a more direct approach and examine what is currently working in the codebase:
<function_calls>


#!/bin/bash

echo "=== Check if the button styles are actually rendered/working currently ==="
echo "Looking for any test files that might show expected behavior:"
find . -type f -name ".test." -o -name ".spec." | xargs grep -l "dialog.*btn|litegraph.*button" 2>/dev/null

echo ""
echo "=== Look at the actual section of litegraph with full context (lines 410-435) ==="
sed -n '410,435p' "src/lib/litegraph/public/css/litegraph.css" | cat -n

echo ""
echo "=== Check what comes BEFORE line 410 for any :root or variable definitions ==="
head -450 "src/lib/litegraph/public/css/litegraph.css" | tail -100 | cat -n


</function_calls>

Let me verify the exact claim: is --text-foreground used only in litegraph.css or elsewhere?
<function_calls>


#!/bin/bash

echo "=== COMPREHENSIVE CHECK: All usages of --text-foreground in entire repo ==="
rg "--text-foreground"

echo ""
echo "=== Check if there are fallback values or alternate definitions ==="
rg "text-foreground|textForeground|text_foreground" -i

echo ""
echo "=== Look at the PR/branch to see if this is new code ==="
git log -1 --name-only 2>/dev/null || echo "Not a git repo"


</function_calls>

Let me check if there's a base CSS or design tokens file that should define these:
<function_calls>


#!/bin/bash

echo "=== Look for any token files or configuration ==="
find . -type f ( -name "token" -o -name "variable" -o -name "theme" ) -name ".css" -o -name ".ts" -o -name "*.js" | grep -E "(token|variable|theme)"

echo ""
echo "=== Check if there's documentation about CSS variables ==="
find . -type f ( -name "README*" -o -name "STYLE*" ) | xargs grep -l "variable|token|css" 2>/dev/null | head -5

echo ""
echo "=== Final verification: Extract exact lines 413-430 from litegraph.css with line numbers ==="
sed -n '413,430p' "src/lib/litegraph/public/css/litegraph.css" | cat -n | sed 's/^/413+/'


</function_calls>

Now let me search for all defined CSS custom properties to create a comprehensive list:
<function_calls>


#!/bin/bash

echo "=== FINAL VERIFICATION: All CSS custom properties defined anywhere in the repo ==="
python3 << 'EOF'
import subprocess
import re

Find all CSS files

css_files = subprocess.run(['find', '.', '-name', '*.css', '-type', 'f'],
capture_output=True, text=True).stdout.strip().split('\n')

defined_vars = set()
used_vars = set()

for css_file in css_files:
if not css_file:
continue
try:
with open(css_file, 'r') as f:
content = f.read()

        # Find defined variables (--name: value)
        definitions = re.findall(r'^\s*(-[a-zA-Z0-9\-]+)\s*:', content, re.MULTILINE)
        defined_vars.update(definitions)
        
        # Find used variables (var(--name))
        usages = re.findall(r'var\((-[a-zA-Z0-9\-]+)', content)
        used_vars.update(usages)
except:
    pass

print("=== DEFINED CSS VARIABLES ===")
for var in sorted(defined_vars):
print(f" {var}")

print(f"\n=== USED CSS VARIABLES (total: {len(used_vars)}) ===")
for var in sorted(used_vars):
status = "✓ DEFINED" if var in defined_vars else "✗ UNDEFINED"
print(f" {var} [{status}]")

print("\n=== UNDEFINED VARIABLES (used but not defined) ===")
undefined = used_vars - defined_vars
if undefined:
for var in sorted(undefined):
print(f" {var}")
else:
print(" None found - all used variables are defined!")
EOF


</function_calls>

Based on my comprehensive verification, let me now formulate the rewritten review comment:


The CSS variable --text-foreground used in lines 419, 424, and 429 is undefined and should be replaced with an appropriate token from the design system.

Lines 413-430 of src/lib/litegraph/public/css/litegraph.css reference var(--text-foreground), which is not defined anywhere in the codebase. This will cause CSS to ignore the color property, leaving button text unstyled.

Review available text/color tokens and use the correct variable (e.g., --base-foreground, --text-primary, or --color-text-primary, depending on the design system's defined tokens).

  .litegraph .dialog .btn {
    border: 0;
    border-radius: 4px;
    padding: 4px 20px;
    margin-left: 0px;
    background-color: var(--secondary-background);
-   color: var(--text-foreground);
+   color: var(--base-foreground);
  }

  .litegraph .dialog .btn:hover {
    background-color: var(--secondary-background-hover);
-   color: var(--text-foreground);
+   color: var(--base-foreground);
  }

  .litegraph .dialog .btn.delete:hover {
    background-color: var(--color-danger-100);
-   color: var(--text-foreground);
+   color: var(--base-foreground);
  }
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45eb2ad and d0122e5.

⛔ Files ignored due to path filters (6)
  • browser_tests/tests/nodeSearchBox.spec.ts-snapshots/link-release-context-menu-chromium-linux.png is excluded by !**/*.png
  • browser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-menu-chromium-linux.png is excluded by !**/*.png
  • browser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-chromium-linux.png is excluded by !**/*.png
  • browser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-properties-panel-chromium-linux.png is excluded by !**/*.png
  • browser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-pinned-node-chromium-linux.png is excluded by !**/*.png
  • browser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-unpinned-node-chromium-linux.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • packages/design-system/src/css/style.css (2 hunks)
  • src/lib/litegraph/public/css/litegraph.css (14 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:14.779Z
Learning: Applies to **/*.{vue,html} : Never use `dark:` or `dark-theme:` Tailwind variants - instead use semantic values from `style.css` theme, e.g. `bg-node-component-surface`
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred

Applied to files:

  • src/lib/litegraph/public/css/litegraph.css
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package

Applied to files:

  • packages/design-system/src/css/style.css
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: setup
  • GitHub Check: setup
  • GitHub Check: test
  • GitHub Check: collect
  • GitHub Check: lint-and-format
🔇 Additional comments (5)
packages/design-system/src/css/style.css (1)

138-504: Theme architecture is well-organized with semantic tokens across light/dark modes.

The CSS variable structure supports comprehensive theming:

  • Palette colors (charcoal, smoke, ash, etc.) defined once at top level
  • Semantic tokens (--base-foreground, --primary-background, etc.) mapped per theme
  • Tailwind color aliases in @theme inline for integration

This is a solid foundation for the litegraph migration.

src/lib/litegraph/public/css/litegraph.css (4)

16-30: Context menu and separator styling properly migrated to theme variables.

The conversion from hard-coded colors (#2e2e2e, #999, etc.) to semantic CSS variables improves maintainability and enables cohesive theming. All referenced variables (--comfy-menu-bg, --border-default, --palette-interface-panel-hover-surface, --content-hover-fg) are defined in style.css.

Also applies to: 121-148


249-306: Dialog styling successfully uses theme tokens for colors and typography.

The changes apply consistent theme variables to dialog backgrounds, text, borders, and font rendering. The font declaration at line 304–305 properly separates font size and font-family for clarity.


358-410: Property panel text and background colors properly migrated to theme variables.

The property styling (lines 364, 381–382) now uses semantic tokens (--muted-foreground for labels, --input-text and --component-node-widget-background for values), enabling consistent theming across light and dark modes.


481-510: Menu and dialog separators converted to use --border-default variable.

The danger entry styling (lines 483, 487) and separator backgrounds (lines 504) now reference theme tokens, ensuring UI borders respond to theme changes.

@DrJKL DrJKL force-pushed the drjkl/properties-theme branch from d0122e5 to 91ba29e Compare November 29, 2025 09:50
@DrJKL DrJKL force-pushed the drjkl/properties-theme branch from 91ba29e to 0580ac6 Compare November 29, 2025 09:51
@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Nov 29, 2025
@DrJKL DrJKL merged commit d3aa8df into main Nov 30, 2025
27 checks passed
@DrJKL DrJKL deleted the drjkl/properties-theme branch November 30, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants