Still emit metrics even if there's no dashboard conneciton string

Author: MikeStall

src/WebJobs.Script.WebHost/Diagnostics/FunctionInstanceLogger.cs

@@ -28,20 +28,23 @@ public FunctionInstanceLogger(
             Func<string, FunctionDescriptor> funcLookup,
             IMetricsLogger metrics,
             string hostName,
-            string accountConnectionString,
+            string accountConnectionString, // May be null
             TraceWriter trace) : this(funcLookup, metrics)
         {
             if (trace == null)
             {
                 throw new ArgumentNullException(nameof(trace));
             }
 
-            CloudStorageAccount account = CloudStorageAccount.Parse(accountConnectionString);
-            var client = account.CreateCloudTableClient();
-            var tableProvider = LogFactory.NewLogTableProvider(client);
+            if (accountConnectionString != null)
+            {
+                CloudStorageAccount account = CloudStorageAccount.Parse(accountConnectionString);
+                var client = account.CreateCloudTableClient();
+                var tableProvider = LogFactory.NewLogTableProvider(client);
 
-            string containerName = Environment.MachineName;
-            this._writer = LogFactory.NewWriter(hostName, containerName, tableProvider, (e) => OnException(e, trace));
+                string containerName = Environment.MachineName;
+                this._writer = LogFactory.NewWriter(hostName, containerName, tableProvider, (e) => OnException(e, trace));
+            }
         }
 
         internal FunctionInstanceLogger(

src/WebJobs.Script.WebHost/WebScriptHostManager.cs

@@ -441,14 +441,13 @@ protected override void OnInitializeConfig(ScriptHostConfiguration config)
 
             // Register the new "FastLogger" for Dashboard support
             var dashboardString = AmbientConnectionStringProvider.Instance.GetConnectionString(ConnectionStringNames.Dashboard);
-            if (dashboardString != null)
-            {
-                // hostId may be missing in local test scenarios.
-                var hostId = config.HostConfig.HostId ?? "default";
-                Func<string, FunctionDescriptor> funcLookup = (name) => this.Instance.GetFunctionOrNull(name);
-                var instanceLogger = new FunctionInstanceLogger(funcLookup, _metricsLogger, hostId, dashboardString, config.TraceWriter);
-                hostConfig.AddService<IAsyncCollector<FunctionInstanceLogEntry>>(instanceLogger);
-            }
+
+            // hostId may be missing in local test scenarios.
+            var hostId = config.HostConfig.HostId ?? "default";
+            Func<string, FunctionDescriptor> funcLookup = (name) => this.Instance.GetFunctionOrNull(name);
+            var instanceLogger = new FunctionInstanceLogger(funcLookup, _metricsLogger, hostId, dashboardString, config.TraceWriter);
+            hostConfig.AddService<IAsyncCollector<FunctionInstanceLogEntry>>(instanceLogger);
+
             hostConfig.DashboardConnectionString = null; // disable slow logging
         }