[Fix] Read 'AppDir' path from recipe file. #326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also please merge #316 asap |
cabiste-dev
changed the title
Contributor
Author
|
I'm kinda new to python, so can someone explain to me why the path concatination is done like this? self.default_runtime_path = self.appdir_path / "runtime" / "default"
self.compat_runtime_path = self.appdir_path / "runtime" / "compat"instead of using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this tool only searches for the AppDir in the current working directory (unless
--appdiris used) and completely ignores the path defined in the recipe file.This PR fixes that.
The hirearchy of importance is:
--appdir(if used)recipe.AppDir.path(if found)AppDirin the current working directory